Only set animationClass on dropdown-content when animations are enabled#658
Open
nickschot wants to merge 1 commit intocibernox:masterfrom
Open
Only set animationClass on dropdown-content when animations are enabled#658nickschot wants to merge 1 commit intocibernox:masterfrom
nickschot wants to merge 1 commit intocibernox:masterfrom
Conversation
Author
|
🤦 oh this was added here as in a fix for app behaviour: #628 Double checking... but the current behaviour is also not great as it can break tests/percy in the way I described edit: I think this change is still correct for the described use case, keeps the fix intact and makes it render in tests properly again. Separately from this, the original problem that #628 seems to solve still appears to be broken for dropdowns that are rendered in place regardless of this MR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the dropdown content could be invisible in tests due to the transitioning in class always being set. Could break visual regression testing etc. in cases where the style for this class makes the dropdown invisible